-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __slots__ to timer helpers #9406
Conversation
We use __slots__ almost everywhere else in the codebase, however __slots__ was missing for these helpers related issue #4618
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9406 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 107 107
Lines 35037 35041 +4
Branches 4150 4150
=======================================
+ Hits 34536 34540 +4
Misses 334 334
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sam Bull <[email protected]>
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 24b0e6f on top of patchback/backports/3.10/24b0e6f7c9d5a0815aebdc0dde5ff9a860a550d9/pr-9406 Backporting merged PR #9406 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 24b0e6f on top of patchback/backports/3.11/24b0e6f7c9d5a0815aebdc0dde5ff9a860a550d9/pr-9406 Backporting merged PR #9406 into master
🤖 @patchback |
Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 24b0e6f)
Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 24b0e6f)
Co-authored-by: Sam Bull <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
What do these changes do?
We use
__slots__
almost everywhere else in the codebase, however__slots__
was missing for these helpersrelated issue #4618 (comment)
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no